fix a comment about assert_receiver_is_total_eq #115888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @m-ou-se (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
|
This leads me to wonder how true "doing this assertion without using a method on this trait is nearly impossible" still is, or if we should be generating something like: // before
#[automatically_derived]
impl<$generics> ::core::cmp::Eq for $Thing {
#[inline]
#[doc(hidden)]
#[coverage(off)]
fn assert_receiver_is_total_eq(&self) {
let _: ::core::cmp::AssertParamIsEq<$FieldType>;
}
}
// after
#[automatically_derived]
impl<$generics> ::core::cmp::Eq for $Thing {}
const _: () = {
#[coverage(off)]
fn assert_fields_are_total_eq<$generics>(_: &$Thing) {
let _: ::core::cmp::AssertParamIsEq<$FieldType>;
}
}; |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 28, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#112959 (Change the wording in `std::fmt::Write::write_str`) - rust-lang#115535 (format doc-comment code examples in std::process) - rust-lang#115888 (fix a comment about assert_receiver_is_total_eq) - rust-lang#116211 (more clippy complextity fixes ) - rust-lang#116213 (Document -Zlink-native-libraries) - rust-lang#116215 (Tweak wording of missing angle backets in qualified path) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 28, 2023
Rollup merge of rust-lang#115888 - RalfJung:assert_receiver_is_total_eq, r=dtolnay fix a comment about assert_receiver_is_total_eq "a type implements #[deriving]" doesn't make any sense, so I assume they meant "implement `Eq`"? Also the attribute is called `derive`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"a type implements #[deriving]" doesn't make any sense, so I assume they meant "implement
Eq"? Also the attribute is calledderive.